CVE-2021-26958

An issue was discovered in the xcb crate through 2021-02-04 for Rust. It has a soundness violation because there is an out-of-bounds read in xcb::xproto::change_property(), as demonstrated by a format=32 T=u8 situation where out-of-bounds bytes are sent to an X server.

An issue was discovered in the xcb crate through 2021-02-04 for Rust. It has a soundness violation because xcb::xproto::GetAtomNameReply::name() calls std::str::from_utf8_unchecked() on unvalidated bytes from an X server.

An issue was discovered in the xcb crate through 2021-02-04 for Rust. It has a soundness violation because transmutation to the wrong type can happen after xcb::base::cast_event uses std::mem::transmute to return a reference to an arbitrary type.

The function xcb::xproto::GetPropertyReply::value() returns a slice of type T where T is an unconstrained type parameter. The raw bytes received from the X11 server are interpreted as the requested type. The users of the xcb crate are advised to only call this function with the intended types. These are u8, u16, and u32. This issue is tracked here: https://github.com/rust-x-bindings/rust-xcb/issues/95

An issue was discovered in the xcb crate through 2021-02-04 for Rust. It has a soundness violation because xcb::xproto::GetAtomNameReply::name() calls std::str::from_utf8_unchecked() on unvalidated bytes from an X server.

An issue was discovered in the xcb crate through 2021-02-04 for Rust. It has a soundness violation because bytes from an X server can be interpreted as any data type returned by xcb::xproto::GetPropertyReply::value.

An issue was discovered in the xcb crate through 2021-02-04 for Rust. It has a soundness violation because there is an out-of-bounds read in xcb::xproto::change_property(), as demonstrated by a format=32 T=u8 situation where out-of-bounds bytes are sent to an X server.

## Calls `std::str::from_utf8_unchecked()` without any checks The function `xcb::xproto::GetAtomNameReply::name()` calls `std::str::from_utf8_unchecked()` on the raw bytes that were received from the X11 server without any validity checks. The X11 server only prevents interior null bytes, but otherwise allows any X11 client to create an atom for arbitrary bytes. This issue is tracked here: https://github.com/rust-x-bindings/rust-xcb/issues/96 ## `xcb::xproto::GetPropertyReply::value()` allows arbitrary return types The function `xcb::xproto::GetPropertyReply::value()` returns a slice of type `T` where `T` is an unconstrained type parameter. The raw bytes received from the X11 server are interpreted as the requested type. The users of the `xcb` crate are advised to only call this function with the intended types. These are `u8`, `u16`, and `u32`. This issue is tracked here: https://github.com/rust-x-bindings/rust-xcb/issues/95 ## Out of bounds read in `xcb::xproto::change_property()` `xcb::xproto::change_property` has (among others) the arguments `format: u8` and `data: &[T]`. The intended use is one of the following cases: - `format = 8` and `T = u8` - `format = 16` and `T = u16` - `format = 32` and `T = u32` However, this constraint is not enforced. For example, it is possible to call the function with `format = 32` and `T = u8`. In this case, a read beyond the end of the `data` slice is performed and the bytes are sent to the X11 server. The users of the `xcb` crate are advised to only call this function with one of the intended argument combinations. This issue is tracked here: https://github.com/rust-x-bindings/rust-xcb/issues/94 ## 'Safe' wrapper around `std::mem::transmute()` The function `xcb::base::cast_event()` takes a reference to a `xcb::base::GenericEvent` and returns a reference to an arbitrary type, as requested by the caller (or found via type interference). The function is implemented as a direct call to `std::mem::transmute()`. Since the return type is not constrained, this allows transmution to an incorrect type or a type that is larger than the X11 event that was passed in. X11 events are mostly always 32 bytes large and this function works as intended. Users are advised to only cast to the event structs provided by the `xcb` crate (and hope for the best). This issue is tracked here: https://github.com/rust-x-bindings/rust-xcb/issues/78