GHSA-ppf9-4ffw-hh4p

Feathers has an open redirect in OAuth callback enables account takeover

### Description The `redirect` query parameter is appended to the base origin without validation, allowing attackers to steal access tokens via URL authority injection. This leads to full account takeover, as the attacker obtains the victim's access token and can impersonate them. The application constructs the final redirect URL by concatenating the base origin with the user-supplied `redirect` parameter: ```javascript // https://github.com/feathersjs/feathers/blob/dove/packages/authentication-oauth/src/service.ts#L158C3-L176C4 const { redirect } = query; ... session.redirect = redirect; // https://github.com/feathersjs/feathers/blob/dove/packages/authentication-oauth/src/strategy.ts#L98 const redirectUrl = `${redirect}${queryRedirect}`; ``` Where: - `redirect` = base origin from config (e.g., `https://target.com`) - `queryRedirect` = user input from `?redirect=` parameter This is exploitable when the `origins` array is configured and origin values do not end with `/`. An attacker can supply `@attacker.com` as the redirect value results in `https://target.com@attacker.com#access_token=...`, where the browser interprets `attacker.com` as the host, leading to full account takeover. **Credits**: Abdelwahed Madani Yousfi (@vvxhid) / Edoardo Geraci (@b0-n0-b0) / Thomas Rinsma (@ThomasRinsma) From Codean Labs.